Skip to content
Snippets Groups Projects

Extend TypeScript documentation

Merged Administrator requested to merge ts-updates into master

Created by: felixfbecker

This extends our TypeScript documentation, which I discussed with @lguychard a long time ago and have been wanting to do.

I am also volunteering to own this documentation within the web team as a CODEOWNER.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: codecov[bot]

    Codecov Report

    Merging #10028 into master will decrease coverage by 0.00%. The diff coverage is n/a.

    @@            Coverage Diff             @@
    ##           master   #10028      +/-   ##
    ==========================================
    - Coverage   42.78%   42.77%   -0.01%     
    ==========================================
      Files        1348     1348              
      Lines       74012    74012              
      Branches     6644     6644              
    ==========================================
    - Hits        31664    31662       -2     
    - Misses      39487    39488       +1     
    - Partials     2861     2862       +1     
    Flag Coverage Δ
    #unit 42.77% <ø> (-0.01%) :arrow_down:
    Impacted Files Coverage Δ
    ...d/frontend/internal/authz/bitbucketserver/store.go 67.74% <0.00%> (-0.93%) :arrow_down:
  • Created by: felixfbecker

    Good point! But looking at the other items in the sidebar, the same argument can be made for other items, like testing or telemetry... I'm not sure what counts more, the "specificness" of the docs for the repo, or maintaining cohesion to the rest of the "How to develop Sourcegraph" documentation?

  • Created by: nicksnyder

    I do think there are other things that should be moved to the handbook (but I would like to avoid getting into the discussion of other items that could be moved in this PR). I think it is ok to gradually move things one at a time to the handbook, and we can solve the cohesion problem by crosslinking the docs (e.g. https://about.sourcegraph.com/handbook/engineering/testing#other).

  • Created by: felixfbecker

    Cool, I can move after merging (so we still have history of this change)

Please register or sign in to reply
Loading