Skip to content
Snippets Groups Projects
Closed Code Insights: Sort and limit filters don't work as other filters
  • View options
  • Code Insights: Sort and limit filters don't work as other filters

  • View options
  • Closed Issue created by Administrator

    Created by: vovakulikov

    Follow up for https://github.com/sourcegraph/sourcegraph/pull/34611

    In general, we implemented the sort and limit filter section in a different way compared to other filter sections.

    The problem

    • You can't save "Sort and limit" filters until you changed something in other filters
    • "Sort and limit" filters don't have a filter changed marker (purple dot next to the filter section title)
    • "Default filter applied" is shown even if "Sort and limit" filters have been changed.
    Screenshot 2022-05-31 at 19 23 31

    @AlicjaSuska Personal feedback (from @vovakulikov) it seems like we don't use space in this filters section in an optimal way, have we considered using a different layout for this section?

    Screenshot 2022-05-31 at 19 35 34

    Activity

    • All activity
    • Comments only
    • History only
    • Newest first
    • Oldest first