insights: incorrectly taking /insights to the getting started tab even when insights exist on the instance
Created by: Joelkw
We had logic that shows you the all insights page if there are any insights visible to you, and otherwise the getting started page if not. (Because we want to show you relevant insights if they exist; they do a better job of explaining the feature than the getting started page's fake examples.)
Loom of the incorrect current state (because k8s has insights and it should take me to the all insights dashboard): https://www.loom.com/share/7a83478517df404c86acbdc4bd966fd9?focus_title=1&muted=1&from_recorder=1
This seems to have regressed sometime in the last few days.
Test flow:
- Click the "insights" tab on an instance with insights created
- Correct: You are taken to the "all insights" dashboard
- Incorrect (current state): you are taken to the getting started page.
Also test the opposite case:
- Click the "insights" tab on an instance with no insights created.
- Correct: you are taken to the getting started page
- (Incorrect: you are taken to an empty all insights dashboard)