Skip to content
Snippets Groups Projects
Closed insights bug: dashboards return all insights when no insights are attached
  • View options
  • insights bug: dashboards return all insights when no insights are attached

  • View options
  • Closed Issue created by Administrator

    Created by: CristinaBirkel

    The issue is basically that if there are no UniqueIDs here, it doesn't add a check at all and everything gets returned.

    https://sourcegraph.com/github.com/sourcegraph/sourcegraph@insights/api/view-resolver-all/-/blob/enterprise/internal/insights/store/insight_store.go?L64&utm_source=VSCode-1.4.0#L83:1

    You can test this out by querying the API for a dashboard that has no insights attached, and seeing that it returns back all of the insights as if they were attached.

    Activity

    • All activity
    • Comments only
    • History only
    • Newest first
    • Oldest first