Skip to content

Fix progress bar when previously printed text has color

Warren Gifford requested to merge fix-progress-bar into master

Created by: mrnugget

This change in a previous PR broke the display of the progress bar:

https://github.com/sourcegraph/src-cli/pull/236/files#diff-f88fc84c78d26d5dc5fde4a5223bc866L258

Why did it break? Because the "display progress bar?"-check checked whether the just-printed data ended in a newline or not. That worked until the just mentioned change, after which every line was wrapped in "set color" and "reset color" escape codes. They wouldn't end in \n but in \n\x1b[0m.

The new check fixes the progress bar.

The other two commits fix a typo and remove an unused dependency.

Merge request reports

Loading