authz: use smaller interface to mock GitHub client in tests (!9808) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge jc/github-perms-tests into master Apr 13, 2020

Created by: unknwon

This is another effort to help remove global mocks for using GitHub API client, based on discussions in https://github.com/sourcegraph/sourcegraph/pull/9655, which defines a smaller interface and a client adapter/wrapper to be used in code, and a mock client in tests.

Special thanks to @keegancsmith :)

authz: use smaller interface to mock GitHub client in tests

Merge request reports