Skip to content

fix regression in GraphQL field monitoring

Warren Gifford requested to merge sg/fix-regression into master

Created by: slimsag

69763d8 introduced selective tracing, in which data to OpenTracing should only be sent selectively. However, the implementation of this was broken in the GraphQL tracing because it turned off ALL tracing of GraphQL requests and not just OpenTracing/Jaeger tracing of GraphQL requests.

This meant that:

  • Prometheus/Grafana could no longer monitor GraphQL error rates or performance (e.g. for search).
  • Admins would no longer see logs for unknown GraphQL queries (which are the only way to currently debug when an API consumer is being too aggressive or issuing queries that are harming the entire system).

This PR fixes the regression by only disabling OpenTracing / span generation.

cc @beyang

Merge request reports