Skip to content

LSIF: Fix bad dump manager interface

Warren Gifford requested to merge lsif-paper-cut-fixes into master

Created by: efritz

Splitting the lsif-server into an api and a dump manager caused some issues with find refs. The packageInformation endpoint and the monikerResult endpoints both had some issues:

  • the api was passing modelType, not model, causing a 422 on all find refs
  • the api is passing an Id, which can be string|number, but we assumed it was always number

The later can be fixed more permanently with some updates to the processor (which we are currently discussing).

Merge request reports