Skip to content

LSIF: Adjust positions on location connection resolver

Warren Gifford requested to merge lsif-diff-pushing-location-resolver into master

Created by: efritz

Current behavior:

  • hover over a definition in commit c
  • get a definition result from LSIF index at nearest commit c-n
  • click on it, takes you to commit c-n

New behavior:

  • hover over a definition in commit c
  • get a definition result from LSIF index at nearest commit c-n
  • attempt to map the position in commit c-n to the equivalent position in commit c
  • click on it, keeps you in same commit

If there are edits or we can't otherwise adjust the position, the current behavior will still occur.

Merge request reports