Skip to content

Fix cancellation for GraphQL requests

Warren Gifford requested to merge web/fix-cancellation into master

Created by: eseliger

Due to a bug in the fromFetch method, cancellation is not working when using response.json. That lead to repeatWhen for example not correctly unsubscribing, basically fetching forever even after a component was unmounted.

This is also currently happening on pages for repos that are having a cloning status, after leaving the page, they will be fetched until it's done cloning.

(see network tab) Before: 2020-03-15 04 26 45

After: 2020-03-15 04 26 17

Merge request reports

Loading