Skip to content
Snippets Groups Projects

src-expose: remove subcommand flagsets

Merged Warren Gifford requested to merge core/src-expose-feedback into master

Created by: keegancsmith

They are unused. Except in one case where there was both a globalAddr and a serveAddr. It was confusing which one took priority, so instead we remove both.

Merge request reports

Merged by avatar (Jun 22, 2025 10:43pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: codecov[bot]

    Codecov Report

    Merging #9005 into master will decrease coverage by <.01%. The diff coverage is 0%.

    @@            Coverage Diff             @@
    ##           master    #9005      +/-   ##
    ==========================================
    - Coverage    41.7%   41.69%   -0.01%     
    ==========================================
      Files        1314     1314              
      Lines       70890    70895       +5     
      Branches     6550     6550              
    ==========================================
      Hits        29563    29563              
    - Misses      38631    38636       +5     
      Partials     2696     2696
    Impacted Files Coverage Δ
    dev/src-expose/main.go 9.09% <0%> (-0.25%) :arrow_down:
    dev/src-expose/serve.go 0% <0%> (ø) :arrow_up:
Please register or sign in to reply
Loading