Register a comlink transfer handler for URLs (!8877) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge comlink-urls into master Mar 07, 2020

Created by: felixfbecker

This is why https://github.com/sourcegraph/code-intel-extensions/pull/303 was not working. The URL objects got serialized to {}, which meant the baseUri was there, but toString() returned [object Object] and did not match the URI, causing no providers to be called. This will also be helpful to replace more uri properties in the extension API with URL types in the future.

I verified that codeintel now works (together with https://github.com/sourcegraph/code-intel-extensions/pull/303):

Register a comlink transfer handler for URLs

Merge request reports