Skip to content
Snippets Groups Projects

auth: GitHub authentication fixes

Closed Warren Gifford requested to merge core/github-auth-fixes into master

Created by: tsenart

This PR fixes a regression introduced in #7331 and reported in #7518 (closed) as well setting a well-typed default for the new allowOrgs setting.

The issue was that oauth.getProvider does a concrete type assertion and in the previous PR we changed what was stored in as the interface implementation to a wrapper type.

Fixes #7518 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
Please register or sign in to reply
Loading