more closely dogfood our recommended LSIF action
Created by: sqs
Do not continue on error. If an error occurs, we want to see it because it means our users likely are seeing it, too. Note that we can still merge because LSIF is not a required PR check (so this change will not prevent us from fixing our site if it's down and the only way to fix it is by merging a new commit).
@chrismwendt Why was continue-on-error set?
Merge request reports
Activity
Created by: codecov[bot]
Codecov Report
Merging #7349 into master will decrease coverage by
<.01%
. The diff coverage isn/a
.@@ Coverage Diff @@ ## master #7349 +/- ## ========================================== - Coverage 39.73% 39.72% -0.01% ========================================== Files 1245 1245 Lines 65888 65890 +2 Branches 6180 6180 ========================================== Hits 26178 26178 - Misses 37310 37312 +2 Partials 2400 2400
Impacted Files Coverage Δ cmd/frontend/internal/app/ui/handlers.go 42.3% <0%> (-0.67%)
Please register or sign in to reply