Skip to content

LSIF: Fallback to original values when project root cannot be resolved

Warren Gifford requested to merge lsif-resolvers-unknown-commit into master

Created by: efritz

This applies for dumps and uploads. When a commit that has LSIF data gets force-pushed over, it's impossible to resolve the projectRoot: GitTree!, which the UI attempts to use in order to show the repo, commit, and path for that dump. This PR attaches that info as a sibling to projectRoot so that it's always present, and makes projectRoot: GitTree nullable.

This exposes the original repository, commit, and root arguments for uploads and dumps so they can be shown in the UI.

This is currently problematic on dot-com right now, which throws both a GraphQL error (on the code intel repo panel) and a frontend null pointer exception (in site-admin uploads list).

Merge request reports