Skip to content

Gitlab: fix command palette overflow

Warren Gifford requested to merge gitlab-command-palette-style into master

Created by: lguychard

Fixes #6151 (closed)

The fix here is to stop applying the popover class to the popover by default, as in Gitlab styles a .popover has a max width (while in Sourcegraph styles .command-list has a fixed width of 24rem).

The Bootstrap popover class was applied in shared/src/commandPalette/CommandList.tsx, it wasn't intentionally used to match Gitlab styles.

Since with this fix, the popover class will no longer be applied by default on other code hosts either, I verified that display of the command palette on GitHub and Bitbucket Server was unaffected. No need to check on Phabricator, where we still don't inject the command palette.

Merge request reports