search pagination: add extensive tests for slicing + fix critical issues (!6099) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge sg/pagination-fixes into master Oct 18, 2019

Created by: slimsag

This PR fixes two critical issues with the search pagination API:

Additionally, I used TDD and added extensive tests for sliceSearchResults which was the source of all the bugs I fixed here.

Test plan: see new tests added

search pagination: add extensive tests for slicing + fix critical issues