site_alerts: add runtime validation for critical.externalURL (!5959) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge jc/show-runtime-site-alert-for-externalURL into master Oct 11, 2019

Created by: unknwon

This PR adds runtime validation for configuration apart from using conf.ContributeValidator because latter will prevent server from starting. Only externalURL is validated at this point.

This fixes the original problem reported in https://github.com/sourcegraph/sourcegraph/issues/3899.

Test plan: Comment out externalURL in dev-private and see if the site alert shows up. And disappear after set a non-empty value via management console.

UI preview:

site_alerts: add runtime validation for critical.externalURL

Merge request reports