Skip to content

fix: update so usage of guest users is subject to a valid license

Warren Gifford requested to merge guests into master

Created by: dadlerj

Per Sourcegraph pricing, having unlimited guest users requires a valid Sourcegraph Elite license key. This PR adds enforcement.

A few questions/downsides:

  • Should the additions to conf.go go into a separate OSS package? Not sure the right home.
  • Stripe billing and associated code still needs to be updated to match new product tiers.
  • Several features that have been moved into higher tier plans (such as Enterprise Plus) are already in use by existing Enterprise customers (such as ACLs). It seems as though this is fixable via the check on this line but this will require re-issuing new license keys to all affected customers.
  • My biggest concern: there's no way (that I can find?) to show an error in the management console to the admin who attempts to set "auth.public" = true... Instead, this will just silently fail. Any suggestions here? Do we have a good way to share errors during config updates, or alternatively, to show errors to admins asynchronously?

CC @juliasourceress

Merge request reports