editorService & modelService refactor and optimizations
There are no commits yet
Push commits to the source branch or add previously merged commits to review them.
Created by: lguychard
Still a fair bit of cleanup to do here, but this introduces some significant improvements towards https://github.com/sourcegraph/sourcegraph/issues/5172.
Notable changes:
Map
s, rather than immutable arrays.editorService.activeEditorUpdates
, to avoid needless iteration over all editors when computing context keys.editorService.activeLanguages
(still very rough, may move to modelService) to avoid needless iteration over all editors when computing active extensions.All tests passed before I started working on 3. and 4.
On the 999-file PR (https://github.com/sourcegraph/sourcegraph/pull/5157/files#diff-1de4be34265b5e830d0e2a2fea7f386bR866), I was able to reliably load up to 400 code views, including blob fetching, in <90seconds. On the same PR, an extension built from master stalls after 270 code views loaded in ~5 minutes.
Push commits to the source branch or add previously merged commits to review them.