all: fsync path and directory when we rely on atomic renames (!4366) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge core/search-store-fsync into master Jun 05, 2019

Created by: keegancsmith

We have seen cases where corrupt zip files exist on disk. We fixed that by evicting bad archives. However, this was likely due to OS caches not being flushed. We now flush both the file and the directory.

For context on why we call fsync see https://lwn.net/Articles/457667/

all: fsync path and directory when we rely on atomic renames

Merge request reports