Skip to content
Snippets Groups Projects

ci: reenable prettier and enable ESLint for all workspaces

Open ci: reenable prettier and enable ESLint for all workspaces
vb/reenable-prettier into main
Open Warren Gifford requested to merge vb/reenable-prettier into main

Created by: valerybugakov

Context

Re-enabling the prettier CI check disabled here. The original issue was found in the external contribution PR and was discussed in the Slack thread.

During the investigation of the prettier issue, I found out that we do not run the ESLint check for the VSCode package. This PR fixes that. Changes from this PR are tested on top of the external contribution changes in this draft PR.

Test plan

  1. CI is green.
  2. The prettier check is stable.
  3. The VSCode package is linted with ESLint on CI.

Merge request reports

Approval is optional
The source branch vb/reenable-prettier does not exist. Please restore it or use a different source branch.

Merge details

  • 3 commits and 1 merge commit will be added to main.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply