admin-analytics: fix to count registered users only once across multiple browsers/IDEs

Review changes
Download
Patches
Plain diff

Open admin-analytics: fix to count registered users only once across multiple browsers/IDEs

erzhtor/fix-admin-analytics-to-count-registered-users-once-across-multiple-browsers-ides into main

Overview 0
Commits 1
Pipelines 0
Changes 3

Open Warren Gifford requested to merge erzhtor/fix-admin-analytics-to-count-registered-users-once-across-multiple-browsers-ides into main 2 years ago

Overview 0
Commits 1
Pipelines 0
Changes 3

Created by: erzhtor

Currently, "Analytics / {Feature}" > "Unique users" counts registered users multiple times if they were using on multiple browsers or IDEs. This is true for the "analytics / users" > "Active Users" metric.

This PR fixes to count registered users only once.

Note:

that anonymous users will still be counted multiple times since there is no way to distinguish between devices.

that "forever" deleted (aka nuked) users' devices/browsers/IDEs will still be counted multiple times since we no longer keep their original user ids, thus falling back to anonymous_user_id, which is unique per device/browser/IDE.

Test plan

check the diff
sg start
Open http://localhost:3080/site-admin/analytics/search and the rest of the analytics feature pages
Check that "total/unique" charts load without any errors

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

0 Reviewers

Request review from

Labels

None

Select labels

Manage project labels

Milestone

None

Time tracking

Participants

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.