Skip to content
Snippets Groups Projects

authz: Move locking of emailsCacheMutex

Merged authz: Move locking of emailsCacheMutex
rs/move-mutex-use into main
Merged Warren Gifford requested to merge rs/move-mutex-use into main

Created by: ryanslade

Before we were locking well before actually making any changes to the map which would hold the lock for too long.

Also added some comments around why we lock in a couple of other places as it wasn't obvious.

Test plan

Existing tests pass

Merge request reports

Approval is optional

Merged by avatar (Jun 8, 2025 6:42am UTC)

Merge details

  • Changes merged into main with 3f46cc1b.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Warren Gifford
    Warren Gifford @warren
    Author Owner

    Created by: indradhanush

    Review: Approved

    Changes look good, but just curious how to avoid a future situation when someone accidentally accesses the guarded attribute before it is locked. The current variation would have helped avoid this potential bug.

    And out of curiosity, how did you run into this finding? :grin:

  • Warren Gifford
    Warren Gifford @warren
    Author Owner

    Merged by: ryanslade at 2022-08-22 14:51:43 UTC

Please register or sign in to reply