Skip to content

codemirror file view: Cleanup/simplify sourcegraph extensions integration

Warren Gifford requested to merge fkling/cm-blob-view-cleanup-extensions-integration into main

Created by: fkling

Note: It helps to turn white-space differences off.

This commit simplifies the Sourcegraph extensions code. The different integrations require access to the context object, which provides the extensions API object. So far this was made available via a state field. However since most of the integrations operate on observables it seems much simpler and cleaner to pass that observable to the integrations when they are created.

Test plan

  • Open a file, enable extensions that provide line decorations (e.g. git blame, codecov).
  • If git blame is set to show information for selected lines, selecting a line will show the corresponding git blame information.
  • The status bar will appear
  • Hovering over tokens will show hovercards and document highlights.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports