Skip to content
Snippets Groups Projects

Extension deprecation: Change enableLegacyExtensions flag to default to true

Merged Warren Gifford requested to merge ps/default-enable-legacy-extensions-to-true into main

Created by: philipp-spiess

This PR reverts #39661

Unfortunately fixing the typo revealed a mistake in the JSON struct parsing logic. Since ExperimentalFeatures is defined as a Go struct, its boolean members will always default to false. It appears that the JSON parsing logic is leaving the default value when no property is defined in the config file and thus enableLegacyExtensions is set to false potentially disabling the extensions (even though this should only be the behavior after 4.0)

Test plan

Screenshot 2022-08-08 at 14 31 19

Merge request reports

Merged by avatar (May 7, 2025 6:37am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading