Skip to content

Code Insights: Connect sort and limit filters to the insight handler properly on the single insight page

Warren Gifford requested to merge vk/fix-single-insight-page-filters into main

Created by: vovakulikov

Fixes https://github.com/sourcegraph/sourcegraph/issues/39788 Fixes https://github.com/sourcegraph/sourcegraph/issues/39790

Background

In https://github.com/sourcegraph/sourcegraph/pull/36376 we broke our filtering on the signle insight page. More correct would be we didn't connect these series-like filters to the chart UI card. This PR fixes this. The part of the problem that we didn't catch this is lack of testing for the insight single page. This PR adds some happy path integrations test for this page.

Test plan

  • Try to filter insight on the single insight page. All filters (series sort and limit, search context, repo filters) should work properly and change data on the chart UI
  • Try to create insight with filters you should be redirected to the all insights dashboard.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports