Skip to content

use node 12

Warren Gifford requested to merge node-12 into master

Created by: sqs

This will require an update to the buildkite-agent Docker images and for everyone to install Node 12 locally. I sent up this PR to start the discussion.

Why? Because I want faster/simpler TS tests (#3959), Webpack builds (#3960), hot reloading (#3961), and future eslint migration (because tslint is deprecated).

Why do these things require Node 12? Because they rely on us using Babel 7 for TypeScript transpilation. Due to https://github.com/babel/babel/issues/9609 and https://github.com/istanbuljs/istanbuljs/issues/237, Babel's TypeScript transpiler is incompatible with Jest's (which is just Istanbul's) code coverage instrumentation because of how it interacts with @babel/plugin-proposal-class-properties. Therefore, when running tests, we require Node 12 (which doesn't need that Babel plugin).

Merge request reports