render-pr-preview: check that BUILDKITE_PULL_REQUEST is not false (!39430) · Merge requests · Warren Gifford / sourcegraph · GitLab

Warren Gifford requested to merge mrn/fix-render-pr-preview into main Jul 26, 2022

Created by: mrnugget

Turns out that BUILDKITE_PULL_REQUEST is either a number or false.

Test plan

CI
Test script to confirm checks

pr_number="${BUILDKITE_PULL_REQUEST}"

if [[ -n "${pr_number}" && "${pr_number}" != "false" ]]; then
  echo "we have a PR"
else
  echo "we don't have a PR"
fi