Skip to content

notebooks: improvements to the read-only mode

Warren Gifford requested to merge rn/notebook-read-only-improvements into main

Created by: novoselrok

Improvements:

  • Line height property is now proportional to the font size in Markdown blocks
  • Blocks are not selectable/hoverable in read-only mode
  • Reduced vertical padding between blocks in read-only mode

Screenshots

Current read-only mode:

Screenshot 2022-07-26 at 09 46 20

New read-only mode:

Screenshot 2022-07-26 at 09 46 12

Demo

Left - new read-only mode, Right - old read-only mode

https://user-images.githubusercontent.com/6417322/180952934-f9a2734c-08d7-4ae7-bdf1-888766f3b41b.mp4

Test plan

  • Open a notebook with permissions to edit
  • Notebook should still be editable
  • Open a read-only notebook
  • Blocks should not be selectable
  • Blocks should not have a border on hover

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading