Skip to content

search frontend: do not surface quote notice

Warren Gifford requested to merge rvt/no-quote-notice into main

Created by: rvantonder

Closes https://github.com/sourcegraph/sourcegraph/issues/22628

Our UI will report "searching literally including quotes" even when that doesn't apply to a pattern, but rather just some filter (and so, we are not actually searching for quotes). This notice was introduced at a time when search behavior transitioned and the transition was really painful https://github.com/sourcegraph/sourcegraph/pull/6090.

Today, the behavior has been around for a while and we should now prefer to surface potential issues using our diagnostics framework/Codemirror directly. We also have lucky search in the works to help with the behavior. All in all this notification is adding more confusion than clarity, and not worth fixing in the existing component since we should find better ways to deal with this in the query bar, e.g., with diagnostics.

Test plan

Removes functionality and there are no existing tests, so confirmed manually.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading