Skip to content

Move git-extras functionality to the core workflow

Warren Gifford requested to merge taras-yemets/migrate-git-extras into main

Created by: taras-yemets

Closes https://github.com/sourcegraph/sourcegraph/issues/39433

  1. Migrates git-extras extension functionality to the core workflow (available under extensionsAsCoreFeatures experimental feature). This PR migrates only blame for the whole file mode and omits blame for selected lines mode. Whether we migrate the latter or not depends on the updates to the git blame UI (see this comment) and will be addressed (if needed) in the follow-up PRs. In the file view, blame decorations are displayed only in the column view (see https://github.com/sourcegraph/sourcegraph/pull/36007). The only UI change is that git blame icon migrated from the action items bar (extensions sidebar) to the repo header section (see screenshots).
  2. Makes blame visibility status unique to the page (blame decorations are hidden initially) as opposed to the user setting synced across all the pages (inspired by how blame works in the VSCode for example).

Loom

Screenshots
File view Screenshot 2022-07-26 at 15 21 45
Commit view Screenshot 2022-07-26 at 15 22 44
Compare view Screenshot 2022-07-26 at 15 23 26

Test plan

  • sg start
  • enable extensionsAsCoreFeatures experimental feature
  • ensure that git-extras extension is not loaded/activated
  • ensure git blame works as before on file, commit and compare pages

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading