Skip to content

search: Fix highlight filter focus bug

Warren Gifford requested to merge fkling/codemirror-focus-bug-2 into main

Created by: fkling

It's unsatisfying to find a solution to a problem and not understand why the solution fixes the problem... this is the case here. I don't know how the syntax highlighting extension could interfere with the other extension or the editor focus, especially since it's only executed when the query changes.

But alas, moving the extension after the current filter highlighting extension fixes the issue. ¯\(ツ)

Before/after video:

https://user-images.githubusercontent.com/179026/178593849-a2ebe610-4933-4372-827e-bca251a12eab.mp4

Fixes https://github.com/sourcegraph/sourcegraph/issues/38677 (but in an unsatisfying way...)

Test plan

Enter filter into query. Tab out of the query input. Tabbing out is successful.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading