search: remove advanced toggle for lucky search (!38684) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge rvt/no-lucky-toggle into main Jul 12, 2022

Created by: rvantonder

There are concerns about this toggle confusing users with lucky search:

I've decided to remove it and just default to our default toggles, this because:

Lucky search is not about this UI change and I don't want people to fixate on it. It's easy to fixate on this silly thing when it's really really not the point.
The toggle existed so that you can disable lucky search in the UI and fall back to literal/standard search. This so that I and others wouldn't have to go and change settings to change the default search as an only way to deactivate lucky search. I now have high confidence (lol) that lucky search works well so I'm comfortable just enabling it as the default for internal dog fooding. If someone wants to opt out they won't have the convenience of a toggle, they'll simply have to change their own settings (which is actually potentially harmful because we actually don't want people to set their default to literal now that standard is on the way, but oh well!!)

Test plan

Manual, for experimental feature.