Skip to content
Snippets Groups Projects

Search backend: clean up repo resolver pt. 2

Merged Warren Gifford requested to merge cc/clean-up-repos-2 into main

Created by: camdencheek

Builds off of https://github.com/sourcegraph/sourcegraph/pull/38598

  1. Fix a typo Dependecies
  2. Move dependency fetching logic into another method
  3. Refactor goroutine group to use lib/group to avoid bad behavior when returning early from semaphore error
  4. Make variable declarations more consise
  5. Refactor to avoid mutating fields of a struct, preferring to build the fields then construct the struct with all the parts
  6. Avoid constructing a gitserver client for every rev, instead preferring to store the client on the resolver, which also makes it possible to pass in a mock client.
  7. Remove unused field OverLimit from Resolved

Test plan

Semantics-preserving, unit tests.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
Please register or sign in to reply
Loading