Skip to content

Search for whole line in case of no selection

Warren Gifford requested to merge dv/jetbrains-search-for-whole-line into main

Created by: vdavid

Fixes https://github.com/sourcegraph/sourcegraph/issues/38003

The neat thing about this change is that now the logic for checking whether we can search for the selection is the same as the logic that decides whether the related actions are enabled in the first place. So there is no way anymore for the menu items to be enabled if we can't make a search!

Test plan

  • short loom demo
    • At the end of the demo I said that the "Search selection in repository" feature didn't change—what I meant here was that the rest of its functionality didn't change. The "if there's no selection then search for the whole line" logic is applied for that feature as well.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading