Skip to content

search frontend: highlight queries accurately everywhere

Warren Gifford requested to merge rvt/highlight-query-everywhere-x into main

Created by: rvantonder

We use this other query highlighting stuff in a lot of places and its incomplete:

  • recent searches
  • query suggestions
  • side panel
  • code insights
  • ???

Why work on this now? I want lucky search suggestions to look good and communicate context about regular expression patterns with /.../. Honestly there are so many places that benefit from better contextual highlighting this is a no-brainer. Now the highlighting is mostly complete. It needs additions to handle patterns that I will add in follow up PR.

Screen Shot 2022-07-06 at 1 35 59 PM

Don't be intimidated by the size of the PR, it's just mechanical changes and mapping everything for light/dark theme stuff. You should feel good about even just stamping because I can correct anything in follow up and it leaves things no worse than before :-)

Separately: the order of definitions is a bit out of place across the monaco code, SCSS, and logic case statements. I will make a separate PR to order things consistently in follow up (it's tricky to keep track of adding the additions int his PR alone, I have like 8 windows open to make sure I copy the right definitions :-))

Test plan

updated

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading