Skip to content

search: when clicking a dynamic filter, only log the kind

Warren Gifford requested to merge jp/telemetryfilterclickevents into main

Created by: limitedmage

When clicking dynamic filters (both repo and generic ones), the whole filter is logged. This is a potential security leak as it could reveal repo names of confidential projects to telemetry. This change makes it so only the filter kind (eg. repo, lang) is logged, not the whole filter. This is logged in the {search_filter: kind} argument of the DynamicFilterClicked event (previously, the whole filter value was logged in the {search_filter: value} argument).

Test plan

Use the debugger Network tab to verify only the filter kind is logged, not the full filter value.

image

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading