Skip to content

JetBrains add settings icons to header

Warren Gifford requested to merge dv/jetbrains-add-settings-icons-to-header into main

Created by: vdavid

Fixes https://github.com/sourcegraph/sourcegraph/issues/38154 Fixes https://github.com/sourcegraph/sourcegraph/issues/38144

I've replaced the dialog toolbar with a custom one that has an icon and a title at the left side, and the button at the right.

Grabbing and moving the window just works out of the box, which was a very positive surprise!

I'm using custom icons because coloring the built-in ones with the theme did not work: I could not make their colors match.

UPDATE: I've also added a fix for https://github.com/sourcegraph/sourcegraph/issues/38144 because it was only three lines, and that change was dependent on this PR anyway.

Test plan

  • I've tested it: 2-min Loom
  • @philipp-spiess I think it's the most efficient to go commit by commit, they are small ones.
  • @jjinnii please look at this Loom to see how it looks, and let me know what adjustments to make!

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading