Skip to content

JetBrains: Make resize padding macOS-only and remove bottom padding

Warren Gifford requested to merge ps/jetbrains-resize-paddings into main

Created by: philipp-spiess

Closes #37669 (closed)

Unfortunlaty this is the best I could do. Here are a few observations:

  • On Windows and Linux, the padding is not necessarily needed. Without it, there are a few fewer pixels that show the resize cursor but I still found it usable. In addition, I was not able to reproduce the issue where resizing would suddenly "stop" on those platforms. Hence I think it makes sense to not show these paddings on that platforms.
  • On macOS, the left and right paddings are still necessary. Without it, the resizing would stop during the interaction. I also tried to play around with adding custom event listeners (the same way that the StatusText component does internally that is used by the JBPanelWithEmptyText component but I was not able to make it work no matter what I tried :( I did notice, however, that the bottom padding does not seem to be necessary anymore.

Test plan

(Put a video on Google drive since it was exceeding the 100MB limit and I already recorded it via QuickTime instead of Loom. Old habits die hard 🙈)

https://drive.google.com/file/d/1uRNCQxm6bFdHBXryNAhVuHfx5f6Hosbd/view?usp=sharing

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading