Skip to content

graphqlbackend: standardize *schemaResolver instantiation

Warren Gifford requested to merge standardize-schemaresolver-init into main

Created by: bobheadxi

This PR updates all direct instantiations of *schemaResolver to use the newSchemaResolver() constructor, which now also sets a logger (currently just from global scope). It's not as minimal of an instantiation as before, but in practice I doubt it'll make much of a difference, and allows us to safely initialize the logger on this struct for use (e.g. https://github.com/sourcegraph/sourcegraph/pull/38130#issuecomment-1174075892)

Test plan

Tests pass, and functionally it does more or less the same thing as 99% of callsites before which would use &schemaResolver{db: db}, except with some added initialization.

Merge request reports