Skip to content

Code Insights: Reuse series picker in compute insight creation UI page

Warren Gifford requested to merge vk/re-use-series-picker-for-compute-insight into main

Created by: vovakulikov

Part of https://github.com/sourcegraph/sourcegraph/issues/37965 Fixes https://github.com/sourcegraph/sourcegraph/issues/38132 https://github.com/sourcegraph/sourcegraph/issues/37785

Background

Screenshot 2022-07-05 at 13 29 27

This PR adopts the 'FormSeries' component and reuses it on the compute-powered insight page.

Test plan

  • Make sure that all interactions with data series on the search-based creation UI page work correctly (edit data series, remove, add new one)
  • Make sure that this logic works in the same way for the compute-powered insight creation UI

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading