Skip to content

batches: Fix preview selections

Warren Gifford requested to merge rc/changeset-selection into main

Created by: Piszmog

Closes #37397 (closed)

In the Issue, we listed just tackling Step 6. After digging around in the code, it was easier to just try and fix everything vs fighting to fix Step 6.

I decided to add an additional state to BatchChangePreviewContextState to track when the filter (search query) changed. I used this state to determine whether to replace or add to the current list/state of the visible changesets.

Test plan

Existing storybooks, unit tests, and functional testing (see recording below).

https://user-images.githubusercontent.com/38407415/176771832-da9dfc07-5603-4721-a417-6dd74a3991c2.mov

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading