Skip to content

search: Fix invalid DOM nesting error on search page

Warren Gifford requested to merge fkling/fix-dom-nesting into main

Created by: fkling

In development mode, React throws the following error (only relevant stack trace):

Warning: validateDOMNesting(...): <th> cannot appear as a child of <thead>.
th
thead
table
div
div
div
PanelContainer@webpack-internal:///./src/search/panels/PanelContainer.tsx:22:24
SavedSearchesPanel@webpack-internal:///./src/search/panels/SavedSearchesPanel.tsx:65:28
[...]

Test plan

Going to https://sourcegraph.test:3443/search doesn't throw that error anymore.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports