Skip to content

Code Insights: Fix filters layout section on the standalone insight page

Warren Gifford requested to merge vk/fix-filters-layout-section into main

Created by: vovakulikov

Closes https://github.com/sourcegraph/sourcegraph/issues/36214

Background

Before After
Screenshot 2022-06-16 at 14 28 38 Screenshot 2022-06-16 at 14 27 42
Same as above Screenshot 2022-06-16 at 14 27 28

For reviewers

@AlicjaSuska I remember that we had a conversation that it would be better to have a collapsable panel for the mobile screen that we already have on the dashboard page. I agree with this but it turned out this requires more work than I'd expected originally. I propose to make this PR improvement first and include this fix in the 3.41 release after we can go back to this page and adopt a collapsable pattern there.

Test plan

  • Go to the standalone insight page (for insight with and without sort and limit filters section)
  • Make sure that layout works properly for desktop and mobile viewports)

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading