JetBrains: Constrain the maximum size of the context menu dropdown (!37272) · Merge requests · Warren Gifford / sourcegraph

Warren Gifford requested to merge ps/fix-search-context-dropdown-max-height into main Jun 15, 2022

Created by: philipp-spiess

This PR adds a constraint to the maximum height of the search context dropdown element. This is necessary because when we render it inside our JetBrains window, we only have limited height available (a problem that the web client luckily doesn't have--yet?).

Unfortunlaty this is not a complete fix as we calculate the available offset based on the hardcoded position on where the dropdown opens inside the JetBrains extension. For a full fix we'd need to pass in the top offset that the DropdownMenu calculates but I haven't find an easy way to do this in the docs.

Changes to the upstreams components:

I added a display: flex to the search menu container so that it responds to a changed max-height. This does not change the visual appearance so I thought upstreaming this is fine?
I added a way to pass-through a className property to the search menu container so that a caller can constraint it's size.