Skip to content

search: link to skipped files on repo status page

Warren Gifford requested to merge sh/not-indexed into main

Created by: stefanhengl

With this change we display the number of skipped files next to the indexed branch/revision on the repository's status page. The user can click on the text to display the list of skipped files. So far, this information was hidden from the admins, which led to many customer issues regarding "missing files".

Background: During indexing, Zoekt may decide to skip a document for various reasons. If a document is skipped, Zoekt replaces the content of the skipped document with "NOT-INDEXED: "

not-indexed

Test plan

  • existing tests
  • manual testing
    • enabled multi-branch indexing and search on a local instance
"experimentalFeatures": {
    "searchMultipleRevisionsPerRepository": true,
    "search.index.branches": {
      "github.com/sourcegraph/sourcegraph": [
        "main",
        "fj/welcome",
      ],
    },
    "search.index.revisions": [
      {
        "name": "^github.com/sourcegraph/sourcegraph$",
        "revisions": [
          "3.39",
        ]
      }
    ]   
  }
  • tested the new link and compared the numbers to the stats displayed on the results pages
  • deleted an index from disk and made sure the status page doesn't break

Merge request reports