Skip to content

GitLab

Explore

Sign in
Register

Primary navigation

Project

S

sourcegraph
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Wiki
- Snippets
- Package registry
- Model registry
- Environments
- Terraform modules
- Incidents
- Value stream analytics
- Model experiments

Snippets Groups Projects

!37035

An error occurred while fetching this tab.

sg: use 1pass instead of dev-private

Review changes
Download
Patches
Plain diff

Closed sg: use 1pass instead of dev-private

sg-hack-hour-06-10/drop-dev-private into main

Overview 4
Commits 2
Pipelines 0
Changes 3

Closed sg: use 1pass instead of dev-private

Warren Giffordrequested to merge

sg-hack-hour-06-10/drop-dev-private into main Jun 10, 2022

Overview 4
Commits 2
Pipelines 0
Changes 3

Created by: jhchabran

Drop dev-private entirely in favour of 1password.

Fixes https://github.com/sourcegraph/sourcegraph/issues/29640

Find a better name for sg secret download-config
Provide a better error when running enteprise code without having ran the command
Maybe plug the requires_dev_private: true field to call sg secret download-config's code automatically ?

Test plan

deleted ../dev-private
ran sg secret download-config (with 1pass from sg setup configured)
ran sg start and got it working, with the right site-config and license.

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Loading

Labels

3

cla-signed sg team/devx

3

cla-signed sg team/devx

Select labels

Manage project labels

Milestone

None

None

None

Time tracking

No estimate or time spent

1

1 Participant

There are no commits yet

Push commits to the source branch or add previously merged commits to review them.

Loading