batches: fix timeline modal overflow

Review changes
Download
Patches
Plain diff

Merged batches: fix timeline modal overflow

kr/timeline-overflow into main

Overview 1
Commits 4
Pipelines 0
Changes 5

Merged Warren Gifford requested to merge kr/timeline-overflow into main 3 years ago

Overview 1
Commits 4
Pipelines 0
Changes 5

Created by: courier-new

Closes https://github.com/sourcegraph/sourcegraph/issues/36184.

This PR does a couple things to make the timeline modal with everything expanded overflow better:

Moves the modal position from top third (default) to center
Caps the max height of the modal to just under the visible screen height
Wraps the actual timeline modal contents in overflow: auto so that it's scrollable

This also fixes the Total Time duration wrapping weirdly in the workspace details.

https://user-images.githubusercontent.com/8942601/172937615-89a578bc-74d1-4c39-93ee-a75134744902.mov

Test plan

Manually tested across different screen sizes (sorry, mobile users) with different states of expanded timeline contents.

App preview:

Web
Storybook

Check out the client app preview documentation to learn more.

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Labels

cla-signed server-side team/batchers

Select labels

Manage project labels

Milestone

None

Time tracking

No estimate or time spent

1 Participant

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.