Skip to content
Snippets Groups Projects

frontend: Use generic timeout in integration test

Merged Warren Gifford requested to merge fkling/integration-tests into main

Created by: fkling

I'm extracting Percy / general integration test stuff from #36044 into a separate (this) PR.

While working on integration tests for the search query input and trying to figure out how to handle waiting on the editor if we want to be able to test different editor implementations (Monaco/CodeMirror), I noticed that the timeout for waiting on the editor gives other components time to "settle". This became evident after I removed one of the editor checks.

But that means that irrespectively of whether or not an editor is rendered on the page, there are pages with components which need time to settle. Using a generic timeout (instead of waiting for something that doesn't exist anyway) expresses that intent better. And that generic timeout also will leave enough time for the editor(s) to update.

I also flipped the order in which we take screenshots so that we don't have to switch back the color scheme (and wait for that) again (the assumption seems to be that light mode is default).

Test plan

CI tests should pass.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Merged by avatar (May 5, 2025 9:39am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading